Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix module chart: fixes validation error in the case where null value… #662

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix module chart: fixes validation error in the case where null value… #662

merged 1 commit into from
Sep 4, 2023

Conversation

spylacopa
Copy link
Contributor

…s are returned

Closes # .

Changes

  • changed properties of ChartResultArrayQuote and ChartIndicatorQuote (allowing null now)

Type

  • New Module
  • Other New Feature
  • Validation Fix
  • Other Bugfix
  • Docs
  • Chore/other

Comments/notes

@gadicc gadicc merged commit 83233fb into gadicc:devel Sep 4, 2023
gadicc added a commit that referenced this pull request Sep 4, 2023
@gadicc
fix(chart/validation): commit updated schema and http fixture (#662)
e99cb18
@gadicc
Copy link
Owner

gadicc commented Sep 4, 2023

Thanks so much, @spylacopa! Very welcome PR. This will be in the next release and there'll be an automated message here once its published. Great first contribution 🙏

gadicc added a commit that referenced this pull request Sep 4, 2023
@gadicc
chore(chart/validation): run prettier (#662)
48b4f09
gadicc pushed a commit that referenced this pull request Sep 4, 2023
@semantic-release-bot
chore(release): 2.4.6 [skip ci]
0e5a8cf 
## [2.4.6](v2.4.5...v2.4.6) (2023-09-04)

### Bug Fixes

* **chart/validation:** allow null results in some fields ([#662](#662)) ([83233fb](83233fb))
* **chart/validation:** commit updated schema and http fixture ([#662](#662)) ([e99cb18](e99cb18))
@gadicc
Copy link
Owner

gadicc commented Sep 4, 2023

🎉 This PR is included in version 2.4.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gadicc gadicc added the released label Sep 4, 2023
This was referenced Sep 14, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spylacopa @gadicc